Skip to content

Clean up GoReleaser release publishing config#174

Merged
bomly-guy merged 5 commits into
mainfrom
codex/use-goreleaser-release-header
Jun 17, 2026
Merged

Clean up GoReleaser release publishing config#174
bomly-guy merged 5 commits into
mainfrom
codex/use-goreleaser-release-header

Conversation

@bomly-guy

@bomly-guy bomly-guy commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • remove the workflow-generated RELEASE_NOTES.md file and --release-notes argument
  • keep GoReleaser's native release.header as the single release-body intro
  • expand the header to explicitly list generated artifact classes and package-manager publishing outputs
  • remove explicit same-repo pull_request.base blocks for Homebrew and Scoop so GoReleaser no longer tries GitHub's fork-sync API for Bomly-owned package repos
  • keep the WinGet cross-repo base untouched, since that PR targets microsoft/winget-pkgs

This combines the release-note cleanup from #174 with the package repo sync cleanup from #173.

Validation

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml"); puts "release.yml OK"'
  • /Users/ahmed/go/bin/goreleaser check
  • git diff --check
  • make test
  • /Users/ahmed/go/bin/goreleaser release --snapshot --clean --skip=publish

Summary by CodeRabbit

  • Chores
    • Updated release workflow and build configuration to enhance GitHub release notes with improved clarity and more detailed information about included artifacts and supported platforms.

@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Bomly Diff Summary

Compared 5a1184c2c9861b7ffbad24037fb33b225c7fa8f5 to 415b117d26ca4670517644ad5a9ab688bb108d66.

Overview

Status Manifests Dependencies Findings Duration
✅ Pass +0 / ~0 / -0 +0 / ~0 / -0 0 introduced / 0 persisted / 0 resolved 69114ms

Dependency Changes

✅ No dependency changes.

Vulnerabilities

✅ No vulnerability changes.

License Changes

✅ No license changes.

Project Posture

✅ No project posture changes (or --matchers +scorecard was not selected).

Policy Findings

✅ No policy differences were identified.

@bomly-guy bomly-guy changed the title Use GoReleaser header for release notes Clean up GoReleaser release publishing config Jun 17, 2026
@coderabbitai

coderabbitai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 01798186-5f09-493e-99d7-36988d2f77af

📥 Commits

Reviewing files that changed from the base of the PR and between 7f8e484 and 8432773.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • .goreleaser.yaml

📝 Walkthrough

Walkthrough

The release workflow removes the step that generates RELEASE_NOTES.md and the corresponding --release-notes=... argument from the GoReleaser invocation. The GoReleaser config replaces the draft release header with a detailed artifact list and removes pull_request.base overrides from the homebrew_casks and scoops configurations.

Changes

Release Workflow and GoReleaser Config

Layer / File(s) Summary
Remove RELEASE_NOTES.md generation and --release-notes arg
.github/workflows/release.yml
Drops the workflow step that populated $RUNNER_TEMP/RELEASE_NOTES.md and simplifies the GoReleaser args from release --clean --release-notes=... to release --clean.
Expand draft release header and remove pull_request.base overrides
.goreleaser.yaml
Replaces the single-sentence draft release header with a structured, multi-line artifact listing (archives, bomly-lite archives, Linux packages, package-manager manifests, SHA256SUMS, attestations note). Removes pull_request.base from homebrew_casks and scoops blocks, retaining only enabled and draft.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~4 minutes

Possibly related PRs

  • bomly-dev/bomly-cli#171: Added RELEASE_NOTES.md generation and the --release-notes=RELEASE_NOTES.md GoReleaser arg that this PR removes.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: consolidating release notes generation and simplifying GoReleaser's release publishing configuration by removing redundant workflow steps and updating the header content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/use-goreleaser-release-header

Warning

Review ran into problems

🔥 Problems

Stopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a @coderabbit review after the pipeline has finished.


Comment @coderabbitai help to get the list of available commands and usage tips.

@bomly-guy bomly-guy enabled auto-merge (squash) June 17, 2026 09:47
@bomly-guy bomly-guy disabled auto-merge June 17, 2026 09:47
@bomly-guy bomly-guy merged commit fb87325 into main Jun 17, 2026
11 checks passed
@bomly-guy bomly-guy deleted the codex/use-goreleaser-release-header branch June 17, 2026 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant